Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: multiple createdAt columns in query causes conflicts #3506

Merged
merged 3 commits into from
Jul 9, 2022
Merged

fix: multiple createdAt columns in query causes conflicts #3506

merged 3 commits into from
Jul 9, 2022

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Jul 7, 2022

Fixes #3504

Changes proposed in this pull request:
Temporary fix until a more major change is carried out for the longer term.

  • Prepends table name t sort fields before the query is executed.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@SychO9 SychO9 merged commit 4da2146 into main Jul 9, 2022
@SychO9 SychO9 deleted the sm/3504-quickfix-createdAt-sort-in-posts-list branch July 9, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davwheat davwheat davwheat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@SychO9 @davwheat