Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Admin.generalIndexItems extender #4068

Merged
merged 2 commits into from
Oct 12, 2024
Merged

feat: add Admin.generalIndexItems extender #4068

merged 2 commits into from
Oct 12, 2024

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Oct 12, 2024

Part of #4022

Changes proposed in this pull request:
Follow-up improvements related to the admin search UI feature.

  • Allows adding custom admin search index entries through the Admin extender.
  • Adds custom entries for the extension manager.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@SychO9 SychO9 requested a review from a team as a code owner October 12, 2024 11:58
@SychO9 SychO9 self-assigned this Oct 12, 2024
@SychO9 SychO9 merged commit f83020c into 2.x Oct 12, 2024
25 checks passed
@SychO9 SychO9 deleted the sm/admin-search-index-extender branch October 12, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SychO9 SychO9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SychO9