Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add List-Unsubscribe header to emails #4069

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from
Open

feat: add List-Unsubscribe header to emails #4069

wants to merge 2 commits into from
+33 −0

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Oct 12, 2024

Closes flarum/issue-archive#447

Changes proposed in this pull request:
In 2.0 we added email unsubscribe links. This PR adds that link to the email headers following standards.

image

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@SychO9 SychO9 added this to the 2.0 milestone Oct 12, 2024
@SychO9 SychO9 self-assigned this Oct 12, 2024
@SychO9 SychO9 requested a review from a team as a code owner October 12, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SychO9 SychO9

Labels
type/feature
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

Email unsubscribe links
2 participants
@SychO9 @StyleCIBot