Fix reply on locked thread when there is a custom permissions

[shivanshuit914]

Currently users can post reply on locked thread when there is a custom permission for specific tag discussions.

[dsevillamartin]

Won't this code just affect the frontend? Ignoring the fact that this should not be needed because of the DiscussionPolicy, doesn't the serializer just affect the JSON attributes that are sent to the API, not when they are obtained directly from the model?

https://github.com/flarum/lock/blob/master/src/Access/DiscussionPolicy.php#L30-L35

[luceos]

@datitisev good point, I forgot about that. So what the PR needs to do is mutate the DiscussionPolicy instead of just the API attribute.

[dsevillamartin]

@luceos The DiscussionPolicy already contains the code necessary to check for if the user can lock, if that's what you mean - I think this is where we hit the issue with extension priority and all that, caused by flarum/tags.

see comments by David

[clarkwinkelmann]

Could we get a proper issue for this ? I'm unable to replicate, I'll need the exact steps.

If the issue does exist, then this PR doesn't solve anything as it's only affecting the frontend as discussed above. The fix will likely happen inside the discussion policy.

@shivanshuit914 or @luceos (if you replicated) can you please post the steps to reproduce ?

I suspect we'll have to push this to the next release cycle.

[franzliedke]

Agreed, this needs to be solved at the policy level, assuming it is a reproducible problem.

Removing this from beta.11.

[askvortsov1]

This seems to be another instance of flarum/framework#1832, and will be fixed via flarum/framework#2056. I'm going to close this for now, thank you though!