Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more logging on db errors #197

Merged
merged 2 commits into from
Oct 17, 2022
Merged

more logging on db errors #197

merged 2 commits into from
Oct 17, 2022

Conversation

metachris
Copy link
Collaborator

@metachris metachris commented Oct 14, 2022

📝 Summary

This will allow to backfill delivered payloads from the logs if saving delivered payloads to database failed (i.e. in case of a database downtime or restart)

⛱ Motivation and Context

On 2022-10-14 6:14am UTC, Amazon recreated our database, which made the relay unable to save some delivered payloads to the database (after they were successfully delivered).

These are the affected payloads:


@timestamp slot blockHash blockNumber
2022-10-14 06:21:00.038 4908669 0xf1ad5ff6bf1cf3de0bbba4d95c796a602650e62a518fe48c91479bd83d5b5a5f 15744489
2022-10-14 06:21:01.902 4908639 0x7009681c683d3a6e5e6d7f26940cc5f58ccab72b8e7b3879add7d1da4cc24571 15744459
2022-10-14 06:21:06.254 4908667 0x69800f5588cefe1d1d28f84e9fb5e7299a0c0c737cae07d0dd2a2ea6eee848b2 15744487
2022-10-14 06:21:06.438 4908662 0xdab75c4b0904601918e9794ab2b25b1abe29fc05e9fb74b057a865134870d884 15744482
2022-10-14 06:21:06.510 4908657 0xddece5d1f73058f699e0dc3778b9086536af71302b979ecd0c8235d09f12a686 15744477
2022-10-14 06:21:07.022 4908652 0xf6fb5e8286b310addcd56aafd456cb712c1dff66aa15be8181c5d3806899b22c 15744472
2022-10-14 06:21:07.974 4908642 0x34ecbd24c0446b706dc3337e4c6a7249cd776b1ef644f71858d56690972e95f7 15744462
2022-10-14 06:21:10.534 4908646 0x831853027b6f6b508f27d85cf4d982ff728c3597fcd9c93e6f87020d693d33bb 15744466
2022-10-14 06:21:10.538 4908651 0xf6529682f64b2e9652cd3e5ad6c53f615b55ba3ea77cd1570e810f6d9f283d33 15744471
2022-10-14 06:21:11.307 4908641 0xa5e81af249095b2e2677fee08e0b2a34d7df4f74b8516b8f1ec28807a179f35a 15744461
2022-10-14 06:21:12.656 4908655 0xb99a55f5d0290521d9c490bbe46b3b342f32f2244f650272ae159b0c2819eff3 15744475
2022-10-14 06:21:13.350 4908650 0x4c0c8a88ab894c80606ec2208589567aa049b70e472b4a4c4a4b54683ccf480e 15744470
2022-10-14 06:21:13.679 4908645 0x7667af92b2cd7ef09ccc774c6b53a748774cd74775cdf5abe85575ed0bd602dc 15744465


✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy
  • I have seen and agree to CONTRIBUTING.md

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2022

Codecov Report

Merging #197 (97f1e83) into main (194b68d) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
- Coverage   20.68%   20.62%   -0.07%     
==========================================
  Files          19       19              
  Lines        2349     2356       +7     
==========================================
  Hits          486      486              
- Misses       1795     1802       +7     
  Partials       68       68              
Flag Coverage Δ
unittests 20.62% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
database/database.go 0.00% <0.00%> (ø)
services/api/service.go 17.89% <0.00%> (-0.14%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

services/api/service.go Outdated Show resolved Hide resolved
services/api/service.go Outdated Show resolved Hide resolved
@metachris metachris merged commit 016449f into main Oct 17, 2022
@metachris metachris deleted the log-on-db-error branch October 17, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants