Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for bid-export-auto script (deflated last export fix) #294

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

metachris
Copy link
Collaborator

Fix for last part in an export.


✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy
  • I have seen and agree to CONTRIBUTING.md

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2023

Codecov Report

Merging #294 (e7851bb) into main (5c95f03) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #294   +/-   ##
=======================================
  Coverage   23.05%   23.05%           
=======================================
  Files          19       19           
  Lines        2607     2607           
=======================================
  Hits          601      601           
  Misses       1927     1927           
  Partials       79       79           
Flag Coverage Δ
unittests 23.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
echo "SCRIPT_DIR: $SCRIPT_DIR"
# echo "SCRIPT_DIR: $SCRIPT_DIR"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be removed?

@metachris metachris merged commit 42cab92 into main Feb 23, 2023
@metachris metachris deleted the export-scripts2 branch February 23, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants