Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

underflow fix #339

Merged
merged 1 commit into from
Apr 8, 2023
Merged

underflow fix #339

merged 1 commit into from
Apr 8, 2023

Conversation

michaelneuder
Copy link
Collaborator

📝 Summary

cast to int64 for case that getHeader or getPayload arrives before the slot start.

@codecov-commenter
Copy link

Codecov Report

Merging #339 (3ac8f0e) into main (7a49000) will not change coverage.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #339   +/-   ##
=======================================
  Coverage   17.43%   17.43%           
=======================================
  Files          20       20           
  Lines        3752     3752           
=======================================
  Hits          654      654           
  Misses       3015     3015           
  Partials       83       83           
Flag Coverage Δ
unittests 17.43% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
services/api/service.go 12.26% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@metachris metachris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty

@metachris metachris merged commit a2473c2 into main Apr 8, 2023
@metachris metachris deleted the underflow branch April 8, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants