Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make builder, data, and proposer apis optional #362

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

michaelneuder
Copy link
Collaborator

📝 Summary

Allow builder, data, and proposer APIs to be disabled based on env variables. This allows containers to run only the logic they need to serve their APIs.

⛱ Motivation and Context

With the previous set up, all 3 APIs were running anywhere the relay binary was running. Since we have dedicated containers for each API, we want to be able to ensure that only the single API that we are serving is active.

📚 References

NA


✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy
  • I have seen and agree to CONTRIBUTING.md

@codecov-commenter
Copy link

Codecov Report

Merging #362 (6eddd0b) into main (85286f5) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #362   +/-   ##
=======================================
  Coverage   19.34%   19.34%           
=======================================
  Files          20       20           
  Lines        3919     3919           
=======================================
  Hits          758      758           
  Misses       3070     3070           
  Partials       91       91           
Flag Coverage Δ
unittests 19.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@metachris metachris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh that's great! simple and functional 🎉

@metachris metachris merged commit 0c035f9 into main Apr 23, 2023
@metachris metachris deleted the mikeneuder-optionalapis branch April 23, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants