Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove random delays from getPayload #374

Merged
merged 3 commits into from
Apr 28, 2023
Merged

remove random delays from getPayload #374

merged 3 commits into from
Apr 28, 2023

Conversation

michaelneuder
Copy link
Collaborator

📝 Summary

Removing these delays as we don't see them as useful and they only increase the risk of a delayed proposal and a resulting orphaned block.


✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy
  • I have seen and agree to CONTRIBUTING.md

@codecov-commenter
Copy link

Codecov Report

Merging #374 (d3a579a) into main (966fe0b) will increase coverage by 0.01%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
+ Coverage   19.59%   19.61%   +0.01%     
==========================================
  Files          20       20              
  Lines        3971     3967       -4     
==========================================
  Hits          778      778              
+ Misses       3099     3095       -4     
  Partials       94       94              
Flag Coverage Δ
unittests 19.61% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
services/api/service.go 15.42% <0.00%> (+0.04%) ⬆️

services/api/service.go Outdated Show resolved Hide resolved
@metachris
Copy link
Collaborator

thanks, that's a nice cleanup

metachris
metachris previously approved these changes Apr 27, 2023
@metachris metachris merged commit 6829f5f into main Apr 28, 2023
@metachris metachris deleted the mikeneuder-rm-random branch April 28, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants