batch upload known validators to Redis #375
Conversation
use HMSET instead of HSET to upload known validators to Redis
Codecov Report
π£ This organization is not using Codecovβs GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #375 +/- ##
==========================================
+ Coverage 19.92% 22.57% +2.65%
==========================================
Files 21 21
Lines 4056 4110 +54
==========================================
+ Hits 808 928 +120
+ Misses 3145 3055 -90
- Partials 103 127 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
|
# Conflicts: # services/housekeeper/housekeeper.go
|
Asking for a bit of patience, as we're working on other important PRs to get merged first (in particular #380) |
|
Reading up, it seems HMSET is deprecated? https://redis.io/commands/hmset/ |
services/housekeeper/housekeeper.go
Outdated
| @@ -133,6 +133,17 @@ func (hk *Housekeeper) processNewSlot(headSlot uint64) { | |||
| }).Infof("updated headSlot to %d", headSlot) | |||
| } | |||
|
|
|||
| func (hk *Housekeeper) flushKnownValidators(indexPkMap map[uint64]types.PubkeyHex) { | |||
There was a problem hiding this comment.
please rename to saveKnownValidators
|
looks really good. left a few minor comments, and please rebase |
- HMSET=>HSET
|
One more thing to optimize this way would be writing validator registrations to redis: Not sure you want to take it on, but it would be great too |
|
thanks! |
π Summary
batch upload known validators to Redis
Use HMSET instead of HSET to upload known validators to Redis
β± Motivation and Context
Following @metachris request on #373.
β I have run these commands
make lintmake test-racego mod tidyCONTRIBUTING.md