Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] remove bellatrix from main paths #436

Merged
merged 1 commit into from
May 30, 2023

Conversation

michaelneuder
Copy link
Collaborator

📝 Summary

  1. remove bellatrix logic from the main code paths. leaving the types alone for now to ensure any rollback is minimal and easy.
  2. add todos where we will need to add deneb support

⛱ Motivation and Context

  1. the bellatrix code is stale
  2. this will help position us to get the deneb code in place asap

📚 References

#430


✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy
  • I have seen and agree to CONTRIBUTING.md

@codecov-commenter
Copy link

Codecov Report

Merging #436 (c4cf14f) into main (7fe4a70) will increase coverage by 0.20%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
+ Coverage   30.63%   30.84%   +0.20%     
==========================================
  Files          24       24              
  Lines        4661     4623      -38     
==========================================
- Hits         1428     1426       -2     
+ Misses       3040     3005      -35     
+ Partials      193      192       -1     
Flag Coverage Δ
unittests 30.84% <0.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
services/api/blocksim_ratelimiter.go 13.04% <ø> (+0.36%) ⬆️
services/api/service.go 34.75% <0.00%> (+0.61%) ⬆️

Copy link
Collaborator

@metachris metachris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@metachris metachris merged commit f60d65e into main May 30, 2023
@metachris metachris deleted the mikeneuder-remove-bellatrix-hotpath branch May 30, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants