Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename broadcast validation to broadcast mode and add docs #506

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

avalonche
Copy link
Collaborator

πŸ“ Summary

β›± Motivation and Context

πŸ“š References


βœ… I have run these commands

  • make lint
  • make test-race
  • go mod tidy
  • I have seen and agree to CONTRIBUTING.md

@avalonche avalonche requested review from jtraglia and metachris and removed request for jtraglia August 10, 2023 23:05
@codecov-commenter
Copy link

Codecov Report

Merging #506 (0e01140) into main (7df7bdd) will increase coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 13.33%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #506      +/-   ##
==========================================
+ Coverage   31.68%   31.70%   +0.02%     
==========================================
  Files          24       24              
  Lines        4860     4860              
==========================================
+ Hits         1540     1541       +1     
+ Misses       3128     3127       -1     
  Partials      192      192              
Flag Coverage Ξ”
unittests 31.70% <13.33%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Ξ”
beaconclient/mock_beacon_instance.go 63.15% <0.00%> (ΓΈ)
beaconclient/prod_beacon_instance.go 12.59% <0.00%> (ΓΈ)
beaconclient/util.go 24.59% <0.00%> (ΓΈ)
beaconclient/multi_beacon_client.go 41.07% <22.22%> (+0.41%) ⬆️

jtraglia
jtraglia previously approved these changes Aug 10, 2023
Copy link
Collaborator

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one nit.

beaconclient/multi_beacon_client.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avalonche avalonche merged commit aa79e44 into main Aug 11, 2023
4 checks passed
@avalonche avalonche deleted the rename-broadcast-validation branch August 11, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants