-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default MaxHeaderSize to 4kb #206
Conversation
Codecov Report
@@ Coverage Diff @@
## main #206 +/- ##
==========================================
+ Coverage 71.65% 72.11% +0.45%
==========================================
Files 6 6
Lines 621 624 +3
==========================================
+ Hits 445 450 +5
+ Misses 149 148 -1
+ Partials 27 26 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
c4a2a96
to
05f6077
Compare
2d8eef9
to
2de9024
Compare
Please remove the cli flag for it, I'd prefer not accumulating Flags for every setting. If we want to make it configurable then we can start with only an env var, but i don't expect this to change much. Should be fine to just define a constant for now, maybe with am env var override. |
bc92547
to
f9e9745
Compare
f9e9745
to
ada08fc
Compare
thanks 👍 |
* Set max header byte size * remove cli flag
📝 Summary
Add flag for boost to configure max header size, defaulting to 4kb.
⛱ Motivation and Context
This is to prevent DoS attacks by preventing attackers sending oversized headers to mev-boost.
📚 References
✅ I have run these commands
make lint
make test
make run-mergemock-integration
go mod tidy