Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getPayload: log info only if request was cancelled because another relay delivered the payload already #356

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

metachris
Copy link
Collaborator

📝 Summary

  • If two relays delivered the same bid, mev-boost would ask the payload from both relays.
  • As soon as one relay delivers the payload, the request to the other relay is cancelled.
  • This change will only log the information that the request was cancelled instead of logging an error

✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy

@metachris metachris changed the title getPayload: log info if request was cancelled getPayload: log info only if request was cancelled because another relay delivered the payload already Sep 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2022

Codecov Report

Merging #356 (0ae4a0b) into main (af2741f) will increase coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
+ Coverage   81.44%   81.52%   +0.08%     
==========================================
  Files           5        5              
  Lines         679      682       +3     
==========================================
+ Hits          553      556       +3     
- Misses         96       97       +1     
+ Partials       30       29       -1     
Flag Coverage Δ
unittests 81.52% <0.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/service.go 79.41% <0.00%> (+0.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@metachris metachris merged commit 7077a6d into main Sep 28, 2022
@metachris metachris deleted the getpayload-log-ctx branch September 28, 2022 07:15
screwyprof pushed a commit to screwyprof/mev-boost that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants