Enable more golangci checks & remove revive #367
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
.golangci.yml
file from go-boost-utils.make lint
rule from go-boost-utils/mev-boost-relay.gofumpt
with extra checks.fmt.Info
calls withlog.Info
calls.SetFormatter
call.relayMonitorList.String()
thatmakezero
identified.t.Helper()
at the beginning of helper functions."POST"
withhttp.MethodPost
inhttp.NewRequest
calls.⛱ Motivation and Context
Just want to keep things consistent between the three projects.
I may review the disabled checks again later and try to fix some more stuff.
Fixes #306.
✅ I have run these commands
make lint
make test-race
go mod tidy