-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Produce statically linked builds #473
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #473 +/- ##
==========================================
+ Coverage 68.64% 68.88% +0.23%
==========================================
Files 8 8
Lines 1263 1263
==========================================
+ Hits 867 870 +3
+ Misses 346 345 -1
+ Partials 50 48 -2
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
f62f35f
to
0ae5383
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I needed to lookup what -tags osusergo,netgo
did. This article explained things pretty well:
The makefile would benefit from de-duplication, but we can do that in another PR.
@metachris decided to push some changes. If you don't like them, feel free to revert. In these changes, I explicitly define a |
i love it, that's amazing, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🥇
📝 Summary
make build-static
andmake build-portable-static
(to not change defaultmake build
behaviour, and the static builds don't work on macOS)✅ I have run these commands
make lint
make test-race
go mod tidy