-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed two references to the flashbot relay #491
Conversation
Proposing to do this change to have equal exposure for other relays in the readme
The Flashbots Sepolia relay was missing on https://github.com/eth-educators/ethstaker-guides/ , I made a PR to add this: eth-educators/ethstaker-guides#78 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks! There are a few other places that may want to be changed too.
- A reference to the Flashbots' Goerli relay in the contributing guide:
Line 26 in a461652
go run . -goerli -relay-check -relays https://0xafa4c6985aa049fb79dd37010438cfebeb0f2bd42b115b89dd678dab0670c1de38da0c4e9138c9290a398ecd9a0b3110@builder-relay-goerli.flashbots.net |
- A reference to the (out-of-date) Flashbots' Kiln relay:
mev-boost/cmd/test-cli/README.md
Line 67 in a461652
./mev-boost -kiln -relays https://0xb5246e299aeb782fbc7c91b41b3284245b1ed5206134b0028b81dfb974e5900616c67847c2354479934fc4bb75519ee1@builder-relay-kiln.flashbots.net |
- Reference to Flashbots' relay source:
Line 36 in a461652
* [MEV-Boost relay source code](https://github.com/flashbots/mev-boost-relay) |
Codecov Report
π£ This organization is not using Codecovβs GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #491 +/- ##
==========================================
- Coverage 68.88% 68.64% -0.24%
==========================================
Files 8 8
Lines 1263 1263
==========================================
- Hits 870 867 -3
- Misses 345 346 +1
- Partials 48 50 +2
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
the relay-spec and api link is listed in https://github.com/flashbots/mev-boost-relay/
Thanks, I made some additional cleanup based on that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM π₯
π Summary
Change to README.md which removes two references to the flashbots relay
β± Motivation and Context
Proposing to do this change to have equal exposure for other relays in the readme
π References
N/A
β I have run these commands
make lint
make test-race
go mod tidy