Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed two references to the flashbot relay #491

Merged
merged 4 commits into from
Apr 16, 2023

Conversation

fredriksvantes
Copy link
Contributor

πŸ“ Summary

Change to README.md which removes two references to the flashbots relay

β›± Motivation and Context

Proposing to do this change to have equal exposure for other relays in the readme

πŸ“š References

N/A


βœ… I have run these commands

  • make lint
  • make test-race
  • go mod tidy

Proposing to do this change to have equal exposure for other relays in the readme
@fredriksvantes
Copy link
Contributor Author

The Flashbots Sepolia relay was missing on https://github.com/eth-educators/ethstaker-guides/ , I made a PR to add this: eth-educators/ethstaker-guides#78

Copy link
Collaborator

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! There are a few other places that may want to be changed too.

  • A reference to the Flashbots' Goerli relay in the contributing guide:

go run . -goerli -relay-check -relays https://0xafa4c6985aa049fb79dd37010438cfebeb0f2bd42b115b89dd678dab0670c1de38da0c4e9138c9290a398ecd9a0b3110@builder-relay-goerli.flashbots.net

  • A reference to the (out-of-date) Flashbots' Kiln relay:

./mev-boost -kiln -relays https://0xb5246e299aeb782fbc7c91b41b3284245b1ed5206134b0028b81dfb974e5900616c67847c2354479934fc4bb75519ee1@builder-relay-kiln.flashbots.net

  • Reference to Flashbots' relay source:

* [MEV-Boost relay source code](https://github.com/flashbots/mev-boost-relay)

@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2023

Codecov Report

Merging #491 (13278a0) into main (a461652) will decrease coverage by 0.24%.
The diff coverage is n/a.

πŸ“£ This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #491      +/-   ##
==========================================
- Coverage   68.88%   68.64%   -0.24%     
==========================================
  Files           8        8              
  Lines        1263     1263              
==========================================
- Hits          870      867       -3     
- Misses        345      346       +1     
- Partials       48       50       +2     
Flag Coverage Ξ”
unittests 68.64% <ΓΈ> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fredriksvantes
Copy link
Contributor Author

Nice, thanks! There are a few other places that may want to be changed too.

* A reference to the Flashbots' Goerli relay in the contributing guide:

go run . -goerli -relay-check -relays https://0xafa4c6985aa049fb79dd37010438cfebeb0f2bd42b115b89dd678dab0670c1de38da0c4e9138c9290a398ecd9a0b3110@builder-relay-goerli.flashbots.net

* A reference to the (out-of-date) Flashbots' Kiln relay:

./mev-boost -kiln -relays https://0xb5246e299aeb782fbc7c91b41b3284245b1ed5206134b0028b81dfb974e5900616c67847c2354479934fc4bb75519ee1@builder-relay-kiln.flashbots.net

* Reference to Flashbots' relay source:

* [MEV-Boost relay source code](https://github.com/flashbots/mev-boost-relay)

Thanks, I made some additional cleanup based on that!

Copy link
Collaborator

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ₯‡

@metachris metachris merged commit 821e7da into flashbots:main Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants