only run github ci checks once

[metachris]

📝 Summary

Before they were always run twice (once for push and once for PR). This PR makes the checks run only once.

---

✅ I have run these commands

• make lint
• make test-race
• go mod tidy

[codecov-commenter]

Codecov Report

Merging #494 (3d9f29c) into main (9acaf56) will increase coverage by 0.23%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #494      +/-   ##
==========================================
+ Coverage   68.79%   69.03%   +0.23%     
==========================================
  Files           8        8              
  Lines        1269     1269              
==========================================
+ Hits          873      876       +3     
+ Misses        346      345       -1     
+ Partials       50       48       -2     

Flag	Coverage Δ
unittests	69.03% <ø> (+0.23%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[jtraglia]

LGTM 👍 just one nit.

[jtraglia]

Nit: we can remove this section now, right? (for both of the files)

Suggested change

pull_request:

[metachris]

we cannot remove this section, because then the checks wouldn't run on PRs!

[jtraglia]

Though, are you sure this is the desired behavior? Without this, I don't believe it will run CI checks for PRs. And I think it's pretty useful to see the CI checks in PRs.

[ralexstokes]

yeah if anything I'd rather enforce the checks at the PR, then not bother with running them "twice" on the main branch

that being said I am also curious why we need to change from the status quo in the first place?

[avalonche]

I think this is correct, ci checks are running for every pull request (as seen in this PR)

[metachris]

We need to change from status quo because in the current configuration, checks are only run for PRs to the main branch, but they should be run on any PR (i.e. you open a PR to another PR/another branch).

The new configuration is correct -- run checks on every PR, and on any push to main branch too (i.e. after a merge)

[jtraglia]

Okay, sounds good to me 👍