allow skipping relay signature check #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avalonche
reviewed
May 4, 2023
| @@ -28,4 +30,6 @@ var ( | |||
| ServerIdleTimeoutMs = cli.GetEnvInt("MEV_BOOST_SERVER_IDLE_TIMEOUT_MS", 0) | |||
|
|
|||
| ServerMaxHeaderBytes = cli.GetEnvInt("MAX_HEADER_BYTES", 4000) // max header byte size for requests for dos prevention | |||
|
|
|||
| SkipRelaySignatureCheck = os.Getenv("SKIP_RELAY_SIGNATURE_CHECK") == "1" | |||
There was a problem hiding this comment.
Maybe can follow the cli.GetEnvBool convention to allow explicit defaults
There was a problem hiding this comment.
I don't think there is an GetEnvBool method, and this way it's more explicit what's the expected value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Allow skipping of relay signature check with environment variable
SKIP_RELAY_SIGNATURE_CHECK=1.This allows automated test deployments without needing to configure a specific relay private key.
See also #499
✅ I have run these commands
make lintmake test-racego mod tidy