Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wrapper types for get header response #538

Merged
merged 5 commits into from
Jun 27, 2023
Merged

Conversation

avalonche
Copy link
Collaborator

📝 Summary

Previously wrapper types were made to process both bellatrix types from go-boost-utils and attestant types which includes capella types. As part of #529 this removes wrapper types as the bellatrix types from go-boost-utils will no longer be needed.

⛱ Motivation and Context

📚 References


✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2023

Codecov Report

Merging #538 (2720a38) into remove-process-bellatrix-payload (9a16491) will decrease coverage by 0.87%.
The diff coverage is 64.81%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                         Coverage Diff                          @@
##           remove-process-bellatrix-payload     #538      +/-   ##
====================================================================
- Coverage                             71.11%   70.24%   -0.87%     
====================================================================
  Files                                     8        7       -1     
  Lines                                  1177     1099      -78     
====================================================================
- Hits                                    837      772      -65     
+ Misses                                  305      283      -22     
- Partials                                 35       44       +9     
Flag Coverage Δ
unittests 70.24% <64.81%> (-0.87%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/utils.go 75.00% <44.89%> (-7.59%) ⬇️
server/service.go 80.41% <71.05%> (-2.04%) ⬇️
server/mock_relay.go 92.18% <100.00%> (+1.88%) ⬆️

Base automatically changed from remove-process-bellatrix-payload to develop June 26, 2023 13:49
@metachris
Copy link
Collaborator

please rebase

@metachris metachris merged commit 635800e into develop Jun 27, 2023
@metachris metachris deleted the remove-wrapper-types branch June 27, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants