Update CONTRIBUITING.md doc #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metachris
reviewed
Oct 5, 2023
CONTRIBUTING.md
Outdated
| go install honnef.co/go/tools/cmd/staticcheck@v0.3.0 | ||
| go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.49.0 | ||
| go install honnef.co/go/tools/cmd/staticcheck@v0.4.0 | ||
| go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.51.0 |
There was a problem hiding this comment.
Amazing, thanks!
CI uses 1.51.2: https://github.com/flashbots/mev-boost/blob/develop/.github/workflows/lint.yml
not sure how to best unify
There was a problem hiding this comment.
Great! just updated the PR using same CI dependencies
metachris
previously approved these changes
Oct 5, 2023
Codecov Report
β Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #573 +/- ##
===========================================
+ Coverage 69.69% 69.96% +0.27%
===========================================
Files 7 7
Lines 1102 1102
===========================================
+ Hits 768 771 +3
+ Misses 288 287 -1
+ Partials 46 44 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
avalonche
approved these changes
Oct 19, 2023
metachris
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Summary
Fix deprecated dependency versions in documentation. See #572
β± Motivation and Context
π References
β I have run these commands
make lintmake test-racego mod tidy