Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: move mock relay into mock package #642

Merged
merged 5 commits into from
Apr 4, 2024

Conversation

MariusVanDerWijden
Copy link
Collaborator

📝 Summary

This PR moves the mock relay into its own package and moves some shared dependencies into their own packages in order to simplify the server package.

⛱ Motivation and Context

In order to simplify the architecture of mev-boost, it makes sense in my opinion to move certain functionalities into their own package. This makes it easier to reason about components and abstractions and its easier to add some more tests and refactors in the future.
This is just an initial PR to move the files, it changes no behavior. I will send some follow-up PRs to clean up the server code and the mock relay

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 67.01031% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 44.00%. Comparing base (8b662e0) to head (e555c15).

Files Patch % Lines
server/mock/mock_relay.go 35.89% 25 Missing ⚠️
cli/types.go 0.00% 3 Missing ⚠️
server/service.go 89.47% 2 Missing ⚠️
server/types/U256str.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #642      +/-   ##
===========================================
- Coverage    52.37%   44.00%   -8.38%     
===========================================
  Files           14       15       +1     
  Lines         1600     1609       +9     
===========================================
- Hits           838      708     -130     
- Misses         703      845     +142     
+ Partials        59       56       -3     
Flag Coverage Δ
unittests 44.00% <67.01%> (-8.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. Thanks! One thing I'd like to be fixed first though.

server/mock/mock_relay.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

Copy link
Collaborator

@metachris metachris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@metachris metachris merged commit b17921a into flashbots:develop Apr 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants