-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: move mock relay into mock package #642
server: move mock relay into mock package #642
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #642 +/- ##
===========================================
- Coverage 52.37% 44.00% -8.38%
===========================================
Files 14 15 +1
Lines 1600 1609 +9
===========================================
- Hits 838 708 -130
- Misses 703 845 +142
+ Partials 59 56 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable to me. Thanks! One thing I'd like to be fixed first though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
📝 Summary
This PR moves the mock relay into its own package and moves some shared dependencies into their own packages in order to simplify the server package.
⛱ Motivation and Context
In order to simplify the architecture of mev-boost, it makes sense in my opinion to move certain functionalities into their own package. This makes it easier to reason about components and abstractions and its easier to add some more tests and refactors in the future.
This is just an initial PR to move the files, it changes no behavior. I will send some follow-up PRs to clean up the server code and the mock relay