Remove capella types #650
Merged
Remove capella types #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avalonche
force-pushed
the
remove-capella
branch
from
db7675e
to
43d484f
Compare
| message := &builderApiDeneb.BuilderBid{ | ||
| Header: &deneb.ExecutionPayloadHeader{ | ||
| BlockHash: HexToHash("0xe28385e7bd68df656cd0042b74b69c3104b5356ed1f20eb69f1f925df47a3ab7"), | ||
| BaseFeePerGas: uint256.NewInt(0), |
There was a problem hiding this comment.
Why did you add BaseFeePerGas here?
There was a problem hiding this comment.
BaseFeePerGas no longer can be nil in the new deneb.ExecutionPayloadHeader type
MariusVanDerWijden
approved these changes
Jul 13, 2024
jtraglia
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Removing capella types as part of clean up after the Deneb hard fork. Note that due to an SSZ encoding bug in the attestant library for the deneb builder bid, it has been updated to the latest version.
⛱ Motivation and Context
This allows the mev-boost codebase to be more manageable instead of accumulating more code from previous hard forks.
✅ I have run these commands
make lintmake test-racego mod tidy