Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

returns None on empty vec #186

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

returns None on empty vec #186

wants to merge 1 commit into from

Conversation

proxima424
Copy link

📝 Summary

Changed drain_new_orders implementation.
Now it returns None if new_orders is an empty Vec

in reference to #180

@ZanCorDX
Copy link
Contributor

I believe that #180 is wrong, just added a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvush dvush Awaiting requested review from dvush dvush is a code owner

@ZanCorDX ZanCorDX Awaiting requested review from ZanCorDX ZanCorDX is a code owner

@ferranbt ferranbt Awaiting requested review from ferranbt ferranbt is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@proxima424 @ZanCorDX