Parallel sealing #187
Merged
Parallel sealing #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark results for
|
| Date (UTC) | 2024-09-24T18:01:57+00:00 |
| Commit | 40fd377b221b2f700175e7e8cab1aea248052774 |
| Base SHA | ab0529f9ea7fd77456183edec25a97778aeec3ef |
Significant changes
| Benchmark | Mean | Status |
|---|---|---|
| MEV-Boost SubmitBlock serialization/JSON encoding | -27.94% | Performance has improved. |
liamaharon
reviewed
Sep 23, 2024
crates/rbuilder/src/live_builder/block_output/bidding/parallel_sealer_bid_maker.rs
Outdated
Show resolved
Hide resolved
ZanCorDX
force-pushed
the
parallel-sealing
branch
from
1ed46d0
to
40fd377
Compare
dvush
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR replaces the SequentialSealerBidMaker for the ParallelSealerBidMaker to allow concurrent block sealing.
💡 Motivation and Context
Inclution rate went down when we deployed the version using SequentialSealerBidMaker.
✅ I have completed the following steps:
make lintmake test