WIP: Modularize -- Ability for server to be used as a package #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ored client handling code.
Remove old `server` package Refactor cmd package to work with new server Remove `models.go`, remove parts and refactor other parts into either `server.go` or `client.go` Change format of `allowed_hosts` to JSON array from comma separated string
Refactor NewServer and server.run into server file Remove requirement for servers to receive appconfig
Refactor MD5Hash method to not use pointers to strings (go strings are pointers under the hood already anyway) Refactor mysql+redis backend implementation to work with new backend interface and modified client struct Move concern of reading a configuration file to the command line interface
|
Creating new direct PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the WIP for #20. Using Glide rather than Godeps because Glide handles dependencies for the sub-packages
backendsandcmdcorrectly. (Will need to change all the imports etc. to not point to my fork before merging)