Skip to content
This repository has been archived by the owner on Oct 26, 2023. It is now read-only.

update-strategies: add missing "overwrite: true" #326

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

t-lo
Copy link
Contributor

@t-lo t-lo commented Jul 11, 2023

Our butane examples for customising locksmith contain an error: overwrite: true is missing when modifying update.conf. This leads to ignition panicking during provisioning as update.conf already exists:

ignition[1009]: CRITICAL : Ignition failed: failed to create files: failed to create files: error creating /sysroot/etc/flatcar/update.conf: error creating file "/sysroot/etc/flatcar/update.conf": A file exists there already and overwrite is false

This change updates our examples and adds overwrite:true.

Our butane examples for customising locksmith contain an error:
"overwrite: true" is missing when modifying "update.conf".
This leads to ignition panicking during provisioning as "update.conf"
already exists:

ignition[1009]: CRITICAL : Ignition failed: failed to create files: failed to create files: error creating /sysroot/etc/flatcar/update.conf: error creating file "/sysroot/etc/flatcar/update.conf": A file exists there already and overwrite is false

This change updates our examples and adds "overwrite:true".

Signed-off-by: Thilo Fromm <[email protected]>
@t-lo t-lo requested a review from a team July 11, 2023 12:27
Copy link
Contributor

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@t-lo t-lo merged commit cc57b6a into main Jul 11, 2023
@t-lo t-lo deleted the t-lo/fix-update-conf-overwrite branch July 11, 2023 14:01
@pothos
Copy link
Contributor

pothos commented Jul 12, 2023

Thanks, missed that in the migration (the default Ignition behavior switched).

By the way, there is also append: to extend the existing file, might be useful now, too, for some cases where a drop-in is not possible.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants