-
Notifications
You must be signed in to change notification settings - Fork 11
app-emulation/qemu-guest-agent: Import from Gentoo #373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks alright. But:
- Could you add app-emulation/qemu-guest-agent to
.github/workflows/packages-list
? - I think it needs a changelog entry.
- Is there a CI running for these PRs?
CI: http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/581/cldsv/ Will add to workflows package-list. Changelog: does it belong here or in coreos-overlay? |
Doesn't matter - it will be picked up regardless of whether it is here or in portage-stable. Can be added here, since the package itself is in portage-stable. |
CI passed, added changelog and package-list entry, ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully tested on Openstack:
virsh qemu-agent-command instance-0000036f '{"execute":"guest-get-osinfo"}' | jq
{
"return": {
"name": "Flatcar Container Linux by Kinvolk",
"kernel-release": "5.15.74-flatcar",
"version": "3396.0.0+qemu-guest-agent",
"pretty-name": "Flatcar Container Linux by Kinvolk 3396.0.0+qemu-guest-agent (Oklo)",
"version-id": "3396.0.0",
"kernel-version": "#1 SMP Wed Oct 19 08:59:08 -00 2022",
"machine": "x86_64",
"id": "flatcar"
}
}
(NOTE: Image on Openstack must be created with hw_qemu_guest_agent=yes
metadata to start the qemu-ga-systemd.service
)
EDIT: Maybe we can add a mention of this in the documentation, in the ACPI part? https://www.flatcar.org/docs/latest/setup/customization/acpi/
needs a rebase |
Upstream commit 18974c258b2fe62ef81dd0287c34d86ac712c11a
ba0a99b
to
a3ccb1d
Compare
app-emulation/qemu-guest-agent: Import from Gentoo
Import qemu-guest-agent from gentoo.
How to use
Testing done
Build tested.
changelog/
directory (user-facing change, bug fix, security fix, update)/boot
and/usr
size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.