Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

app-emulation/qemu-guest-agent: Import from Gentoo #373

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

jepio
Copy link
Contributor

@jepio jepio commented Oct 18, 2022

app-emulation/qemu-guest-agent: Import from Gentoo

Import qemu-guest-agent from gentoo.

How to use

emerge-amd64-usr qemu-guest-agent

Testing done

Build tested.

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

@jepio jepio requested a review from a team October 18, 2022 17:04
@jepio jepio linked an issue Oct 18, 2022 that may be closed by this pull request
Copy link
Contributor

@krnowak krnowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks alright. But:

  • Could you add app-emulation/qemu-guest-agent to .github/workflows/packages-list?
  • I think it needs a changelog entry.
  • Is there a CI running for these PRs?

@jepio
Copy link
Contributor Author

jepio commented Oct 19, 2022

CI: http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/581/cldsv/

Will add to workflows package-list.

Changelog: does it belong here or in coreos-overlay?

@krnowak
Copy link
Contributor

krnowak commented Oct 19, 2022

Changelog: does it belong here or in coreos-overlay?

Doesn't matter - it will be picked up regardless of whether it is here or in portage-stable. Can be added here, since the package itself is in portage-stable.

@jepio
Copy link
Contributor Author

jepio commented Oct 19, 2022

CI passed, added changelog and package-list entry, ready to merge.

Copy link
Contributor

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested on Openstack:

virsh qemu-agent-command instance-0000036f '{"execute":"guest-get-osinfo"}'  | jq
{
  "return": {
    "name": "Flatcar Container Linux by Kinvolk",
    "kernel-release": "5.15.74-flatcar",
    "version": "3396.0.0+qemu-guest-agent",
    "pretty-name": "Flatcar Container Linux by Kinvolk 3396.0.0+qemu-guest-agent (Oklo)",
    "version-id": "3396.0.0",
    "kernel-version": "#1 SMP Wed Oct 19 08:59:08 -00 2022",
    "machine": "x86_64",
    "id": "flatcar"
  }
}

(NOTE: Image on Openstack must be created with hw_qemu_guest_agent=yes metadata to start the qemu-ga-systemd.service)

EDIT: Maybe we can add a mention of this in the documentation, in the ACPI part? https://www.flatcar.org/docs/latest/setup/customization/acpi/

@dongsupark
Copy link
Contributor

needs a rebase

@jepio
Copy link
Contributor Author

jepio commented Oct 24, 2022

@tormath1 flatcar-archive/flatcar-docs#262

@jepio jepio merged commit 12951f4 into main Oct 24, 2022
@jepio jepio deleted the jepio/qemu-guest-agent branch October 24, 2022 08:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Package Request: [qemu-guest-agent]
4 participants