*: Port to new Azure SDK #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New SDK's azblob package accepts page sets that are 4mb long now, with an additional constraint that each page's boundaries are at 512 byte offsets. This probably was usually the case, just make sure it really is so.
It was jarring and inconsistent, some function names used MetaData, some others used Metadata. Just stick to the latter. The only thing left intact is the name of the JSON key.
Most of the changes are because pageblob.Client represents a specific blob in storage, so it can be passed instead of a triplet of general blob storage client, container name and blob name. On the authentication side, we switch to the azidentity package, but we preserve the possibility of using the discouraged shared key crendetials if --stgaccountkey parameter is passed. Otherwise we will use the managed identity, with an additional requirement that the managed account already has a role that allows the account to save new blobs.
|
I assigned flatcar-maintainers team the write role for this repo, so I can ask the team for the review properly. |
jepio
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes mostly are:
MetaDatatoMetadata--stgaccountkeyif there is a need to use the shared key credentials - these are discouraged now in favor of managed identities, but the upside of shared key credentials is that you don't need to assign the Storage Blob Data Contributor/Owner roles.The follow-up PR will move the high-level upload code from
vhdUploadCmdHandler.goto a separateoppackage, that mantle will be able to use for uploading VHD images.