Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

op: New package containing the high-level upload code #3

Merged
merged 1 commit into from
Jun 12, 2024
Merged

op: New package containing the high-level upload code #3

merged 1 commit into from
Jun 12, 2024

Conversation

krnowak
Copy link
Member

@krnowak krnowak commented Jun 11, 2024

So mantle can easily reuse the code without mucking with making them parallel and such:

  • move the code over to the op subpackage
  • added error codes, so mantle can react to a specific error (the blob being already uploaded IIRC)
  • added context.Context parameter to an upload function to reduce the amount of context.TODO()
  • fixed some copy-pasta in parameter description

@krnowak krnowak requested a review from a team June 11, 2024 15:25
tormath1
tormath1 reviewed Jun 12, 2024
View reviewed changes
op/upload.go Outdated Show resolved Hide resolved
op/upload.go Outdated Show resolved Hide resolved
op/upload.go Outdated Show resolved Hide resolved
op/upload.go Outdated Show resolved Hide resolved
@krnowak krnowak requested a review from tormath1 June 12, 2024 11:52
tormath1
tormath1 approved these changes Jun 12, 2024
View reviewed changes
Copy link

@tormath1 tormath1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
EDIT: Feel free to squash the commits into one.

@krnowak
op: New package containing the high-level upload code
3893a51 
So mantle can easily reuse the code without mucking with making them
parallel and such.
@krnowak krnowak merged commit a90d315 into master Jun 12, 2024
@krnowak krnowak deleted the krnowak/new-sdk branch June 12, 2024 12:21
@github-actions github-actions bot mentioned this pull request Jun 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tormath1 tormath1 tormath1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krnowak @tormath1