Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(openstack): add OVHcloud example #27

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

spnngl
Copy link

@spnngl spnngl commented Aug 1, 2024

[OVHcloud openstack image example]

Add flatcar image import example for OVHcloud.

How to use

Try using this image on OVHcloud, we have used this for years now.

Closes: flatcar/Flatcar#1453

@tormath1
Copy link
Contributor

tormath1 commented Aug 1, 2024

Thanks a lot for this PR I was not expecting this that fast! I think it's better to have the examples in it's own ovhcloud folder to ease the discovering. As it will be almost identical to OpenStack you can just copy the OpenStack folder and update the README.md with the specific OVHcloud bits?

@spnngl spnngl force-pushed the chore/openstack/ovhcloud_example branch from acfea89 to 2f0d39c Compare August 9, 2024 13:34
@spnngl
Copy link
Author

spnngl commented Aug 9, 2024

@tormath1 Just pushed the OVHcloud version, largely copied from Openstack but with some modifications (notably on the image).

@tormath1
Copy link
Contributor

tormath1 commented Aug 9, 2024

@tormath1 Just pushed the OVHcloud version, largely copied from Openstack but with some modifications (notably on the image).

Thanks a lot - I am on vacation from tonight and for a few weeks, I'll have a look at my return (or if someone from @flatcar/flatcar-maintainers wants to review it)

Comment on lines +21 to +25
user_name = var.user_name
tenant_name = var.tenant_name
password = var.password
auth_url = var.auth_url
region = var.region
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can just add a note to the OVH documentation to find those information?

Copy link
Contributor

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! Just one question and it's good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFE] OVHcloud documentation
2 participants