systemd/system/ensure-sysext: skip unit if systemd-sysext is skipped #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unit failed to execute when the dependency systemd-sysext.service was skipped because it's not needed. Normally this is harmless but it still triggers a OnFailure event as reported in flatcar/Flatcar#710 Use the same logic for skipping execution as done in systemd-sysext.service - we can't use "systemctl is-enabled" because Flatcar's inbuilt unit symlinks are not reported as "enabled".
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Apr 12, 2022
This pulls in flatcar/init#68 to skip the ensure-sysext unit when systemd-sysext is skipped to prevent a dependency failure being reported. Closes: flatcar/Flatcar#710
1 task
krnowak
reviewed
Apr 13, 2022
krnowak
approved these changes
Apr 13, 2022
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Apr 13, 2022
This pulls in flatcar/init#68 to skip the ensure-sysext unit when systemd-sysext is skipped to prevent a dependency failure being reported. Closes: flatcar/Flatcar#710
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Apr 13, 2022
This pulls in flatcar/init#68 to skip the ensure-sysext unit when systemd-sysext is skipped to prevent a dependency failure being reported. Closes: flatcar/Flatcar#710
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Apr 13, 2022
This pulls in flatcar/init#68 to skip the ensure-sysext unit when systemd-sysext is skipped to prevent a dependency failure being reported. Closes: flatcar/Flatcar#710
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit failed to execute when the dependency systemd-sysext.service
was skipped because it's not needed. Normally this is harmless but it
still triggers a OnFailure event as reported in
flatcar/Flatcar#710
Use the same logic for skipping execution as done in
systemd-sysext.service - we can't use "systemctl is-enabled" because
Flatcar's inbuilt unit symlinks are not reported as "enabled".
How to use
Test that the built image doesn't contain a log about the unit having failed because of a dependency not being run
Testing done
Works as expected:
ensure-sysext.service was skipped because all trigger condition checks failedchangelog/directory (user-facing change, bug fix, security fix, update)↑ TODO in coreos-overlay