Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/ignition: add networkd translation test #334

Merged
merged 3 commits into from
Jun 3, 2022

Conversation

tormath1
Copy link
Contributor

In this PR, we add a new test to ensure networkd Ignition from spec 2.x is correctly translated to files from spec 3.x and applied correctly.

This has been tested with current stable (where networkd is still supported) and with flatcar-archive/coreos-overlay#1910

Related to: flatcar/Flatcar#741

⚠️ this should be merged after the coreos-overlay's PR merged, backported to alpha/beta and released - otherwise test will fail (except on stable where we still on ignition 2.x so networkd is still supported)

this test can actually be used to identify any regression with
ign-converter and Ignition translation from 2 to 3.

Signed-off-by: Mathieu Tortuyaux <[email protected]>
This commit creates a dummy network interface with a dummy IP assigned.
With recent Ignition, `networkd` is no more used and should be
translated to `files` section.

This test ensures that we keep the `networkd` behavior by translating it with
`ign-converter`.

This test lives with an existing test (both are independant) to not add a new test
and it will run only on QEMU.

Signed-off-by: Mathieu Tortuyaux <[email protected]>
@tormath1 tormath1 self-assigned this May 20, 2022
@tormath1 tormath1 marked this pull request as ready for review May 20, 2022 09:52
@tormath1 tormath1 requested a review from a team May 20, 2022 09:53
Copy link
Member

@dongsupark dongsupark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Probably add changelog?

Signed-off-by: Mathieu Tortuyaux <[email protected]>
@tormath1 tormath1 merged commit d0bd70a into flatcar-master Jun 3, 2022
@tormath1 tormath1 deleted the tormath1/networkd branch June 3, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants