Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kola/tests: Replace nmap's ncat with openbsd ncat #539

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

krnowak
Copy link
Member

@krnowak krnowak commented Jul 5, 2024

OpenBSD netcat has no long flags and has no idle timeout flag, so these need to be replaced with short flags and using a timeout utility, respectively.

@krnowak krnowak force-pushed the krnowak/openbsd-netcat branch 3 times, most recently from 3dab3fd to 8fb4cd1 Compare August 1, 2024 16:08
@krnowak krnowak changed the title kola/test:docker: Prepare for replacing ncat with openbsd nc kola/tests: Replace nmap's ncat with openbsd ncat Aug 1, 2024
@krnowak krnowak requested a review from a team August 6, 2024 06:08
@krnowak
Copy link
Member Author

krnowak commented Aug 6, 2024

Ready for review. The changes in crio and podman tests are untested - we are not running those on Flatcar.

@krnowak
Copy link
Member Author

krnowak commented Aug 6, 2024

@krnowak
Copy link
Member Author

krnowak commented Aug 6, 2024

Just occurred to me that the docker network test will need a split - old version with nmap ncat, new version with openbsd nc.

@krnowak
Copy link
Member Author

krnowak commented Aug 6, 2024

CI on older versions (to test if nmap ncat docker.network still works):

Also rekicked test-dispatcher jobs in CI for the new versions (at http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/4414/cldsv/)

@krnowak
Copy link
Member Author

krnowak commented Aug 6, 2024

CI passed.

@krnowak
Copy link
Member Author

krnowak commented Aug 6, 2024

Will drop the for testing: downgrade a bit. Maybe will even need to bump it more before merging.

Copy link
Contributor

@chewi chewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know Go, but it LGTM.

Nmap's ncat will be replaced in newer versions with OpenBSD nc. But
keep the old test intact, as the older channels still have nmap's
ncat.

The CRIO and podman are untested - they do not run on Flatcar.
@krnowak krnowak merged commit a0b4473 into flatcar-master Aug 9, 2024
2 checks passed
@krnowak krnowak deleted the krnowak/openbsd-netcat branch August 9, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants