coreos-overlay: Add support for new EKS versions #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds download URLs for EKS 1.24, 1.25, 1.26, 1.27 and 1.28 so images can more easily be used for EKS workers. Signed-off-by: Hart Hoover <[email protected]>
hhoover
force-pushed
the
pr/hhoover/eks-versions
branch
from
2d2076a
to
63f825b
Compare
jepio
approved these changes
Oct 5, 2023
Signed-off-by: Jeremi Piotrowski <[email protected]>
This helps track which versions include certain changes because these ebuild revisions show up in the package version list that we publish alongside each release. Signed-off-by: Jeremi Piotrowski <[email protected]>
|
Thanks for this contribution @hhoover, i've pushed an extra commit to include the PR link in the changelog (i know its annoying to do because you only get the pr number after you open the pr). |
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/6420174797 |
|
@jepio looks like builds failed not related to the PR - did I miss something? |
|
No, you did everything right. The failing test cases don't work for PRs from forks, I just ran the CI to see that things build correctly. Again, thanks for this PR. We appreciate when users scratch their own itch :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds S3 download locations for newer EKS versions
Flatcar out of the box only works for EKS 1.23 and older, this adds support for newer versions in the download_kubelet.sh script. This change adds download URLs for EKS 1.24, 1.25, 1.26, 1.27 and 1.28 so images can more easily be used for EKS workers.
Similar to flatcar-archive/coreos-overlay#2110
How to use
Deploy an image as an EKS worker on cluster versions 1.24-1.28 (or just verify the downloads work)
Testing done
Tested S3 download URLs using
aws s3 syncas it is in the script for other versions.changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.