Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image changes reports for extra sysexts #2236

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Conversation

krnowak
Copy link
Member

@krnowak krnowak commented Aug 15, 2024

Currently we generate three extra sysext images (podman, zfs and python). Make sure we get the reports for those too.

Needs flatcar/flatcar-build-scripts#162 first.

CI: Tested together with #2230.

@krnowak krnowak marked this pull request as ready for review August 15, 2024 11:23
@krnowak krnowak requested a review from a team August 15, 2024 11:23
Copy link

github-actions bot commented Aug 15, 2024

We can strip suffixes using an array notation instead of doing it in a
loop. Also drop an unused architecture parameter.
@krnowak
Copy link
Member Author

krnowak commented Aug 15, 2024

Kicked off another batch (to make sure it works; I also added a commit that simplifies two bits of code):

against last nightly, arm64: http://jenkins.infra.kinvolk.io:8080/job/container/job/image_changes/6872/
against last release, arm64: http://jenkins.infra.kinvolk.io:8080/job/container/job/image_changes/6873/
against last nightly, amd64: http://jenkins.infra.kinvolk.io:8080/job/container/job/image_changes/6874/
against last release, amd64: http://jenkins.infra.kinvolk.io:8080/job/container/job/image_changes/6875/

Copy link
Member

@dongsupark dongsupark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the Jenkins links now disappeared, but I trust you.

@krnowak
Copy link
Member Author

krnowak commented Aug 30, 2024

Thanks.

@krnowak krnowak merged commit b69b7bf into main Aug 30, 2024
1 check failed
@krnowak krnowak deleted the krnowak/report-sysexts branch August 30, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants