-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arm64: fix vnc console on qemu-kvm arm64 #830
Conversation
...container/src/third_party/coreos-overlay/sys-kernel/coreos-modules/files/arm64_defconfig-6.1
Outdated
Show resolved
Hide resolved
@pothos the change seems to work as expected, tested with the github artifacts produced by the github action. AFTER: |
Thanks for testing! Please move the change to the |
Sure, need to verify first if the issue is actually present on the amd64 image. |
Hello, I have tested on amd64, and the issue is not reproducing wihout this fix. should I leave the amd64 config unchanged in this case? |
I think it's a good idea to still have it on amd64 even if by default another driver is used. |
23aab8b
to
a1651b7
Compare
Hello @pothos, I have updated the PR with the changes requested. Thank you. |
a1651b7
to
a1be2ae
Compare
Without DRM configured in the Linux kernel, the VNC console will show a screen with the message: "Display output is not active". Although the on QEMU-KVM AMD64 the issue is not presented, I have enabled the same flags for consistency. Fixes: flatcar/Flatcar#1030
a1be2ae
to
c76e969
Compare
Thank, looks good - I'll start a test job now. |
/build-image |
Hello @pothos, I have updated the PR and @gabriel-samfira triggered a PR test suite run here https://github.com/flatcar/scripts/actions/runs/5111437226, which partially passed (kolla still broken). Anything else required for the PR to be merged? Thank you. |
The test job you triggered seems to have been cancelled by another higher priority run: https://github.com/flatcar/scripts/actions/runs/5090846591 -> Canceling since a higher priority waiting request for 'PR command build dispatcher-pr-command-main' exists. |
All good, there are some kernel config changes compared to 5.15 and I don't know if this change or the 6.1 kernel update caused them. Anyway something for a new PR. |
thank you, @pothos. Because CONFIG_DRM is now set, the make old|defconfig should add some more diffs in the resulted config. Possibly this is the difference you are seeing. |
Fixes-Bug: flatcar/Flatcar#1030
testing in progress, PR was made to be able to have a built image.