Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-build: build cri-o for each Kubernetes version #83

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

tormath1
Copy link
Contributor

@tormath1 tormath1 commented Aug 2, 2024

CRI-O is coupled to Kubernetes for the releases, while the major and the minor follows Kubernetes streams, the patch version is independant, so we need to fetch the latest patch release for each minor Kubernetes version.

sysupdate configuration is generated similar to Kubernetes.


Locally tested, will trigger a release right after to generate cri-o missing images.

Related to: #42

@tormath1 tormath1 self-assigned this Aug 2, 2024
@tormath1 tormath1 requested a review from a team August 2, 2024 09:46
release_build.sh Outdated
@@ -25,6 +24,16 @@ fi
KBS_VERS_ARRAY=(${KBS_VERS})
printf "%s\n" "${KBS_VERS_ARRAY[@]}"

echo "Fetching list of latest CRI-O patch releases"
echo "================================================="
git clone https://github.com/cri-o/cri-o
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could get a sorted list of tags without cloning using git ls-remote --tags --sort=-v:refname https://github.com/cri-o/cri-o. You probably could store the output in the file and then process it further to get the latest point release for each kubernetes major version.

But your solution works too, so just saying.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's better you save time comparing to cloning. I did not know that trick. :)

CRI-O is coupled to Kubernetes for the releases, while the major and the
minor follows Kubernetes streams, the patch version is independant, so
we need to fetch the latest patch release for each minor Kubernetes
version.

sysupdate configuration is generated similar to Kubernetes.

Signed-off-by: Mathieu Tortuyaux <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants