-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove access to xdg directories #280
base: master
Are you sure you want to change the base?
Conversation
Started test build 32871 |
Build 32871 successful
|
"--filesystem=xdg-videos:ro", | ||
"--filesystem=xdg-pictures:ro", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to keep these so drag-n-drop from them works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, forgot about drag-n-drop, I'll just keep this PR open as a draft for if that ever gets resolved in Chromium/Electron
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it work in Chromium? I mean is it only Electron issue, or Chromium as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, there is an open issue on the Chromium bug tracker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xdg-download write access could be removed right now tho, as it's not necessary for drag-n-drop (unless there's some other feature that needs it that i'm not aware of)
See electron/electron#30650, contributors are greatly appreciated. |
The 0.0.26 build of the client now ships with Electron 22 which is able to use the file chooser portal
Started test build 44511 |
Build 44511 successful
|
I hope this is merged. It's been more then a year. Users such as me shouldn't have to give Home folder access via Flatseal to fix this. |
Well this request is to remove access... General file usage should work fine, only drag-n-drop from random locations won't, until Electron fixes that. |
The 0.0.26 build of the client now ships with Electron 22 which is able to use the file chooser portal
Closes #99