Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove access to xdg directories #280

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

DaPigGuy
Copy link

@DaPigGuy DaPigGuy commented Apr 5, 2023

The 0.0.26 build of the client now ships with Electron 22 which is able to use the file chooser portal

Closes #99

@flathubbot
Copy link
Contributor

Started test build 32871

@flathubbot
Copy link
Contributor

Build 32871 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/15506/com.discordapp.Discord.flatpakref

Comment on lines -20 to -22
"--filesystem=xdg-videos:ro",
"--filesystem=xdg-pictures:ro",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to keep these so drag-n-drop from them works.

Copy link
Author

@DaPigGuy DaPigGuy Apr 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, forgot about drag-n-drop, I'll just keep this PR open as a draft for if that ever gets resolved in Chromium/Electron

Copy link

@Mart-Bogdan Mart-Bogdan Jun 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work in Chromium? I mean is it only Electron issue, or Chromium as well?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, there is an open issue on the Chromium bug tracker

Copy link

@Ketok4321 Ketok4321 Nov 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xdg-download write access could be removed right now tho, as it's not necessary for drag-n-drop (unless there's some other feature that needs it that i'm not aware of)

@DaPigGuy DaPigGuy marked this pull request as draft April 5, 2023 02:27
@orowith2os
Copy link

See electron/electron#30650, contributors are greatly appreciated.

The 0.0.26 build of the client now ships with Electron 22 which is able
to use the file chooser portal
@flathubbot
Copy link
Contributor

Started test build 44511

@flathubbot
Copy link
Contributor

Build 44511 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/27140/com.discordapp.Discord.flatpakref

@MagmaBro123
Copy link

MagmaBro123 commented May 25, 2024

I hope this is merged. It's been more then a year. Users such as me shouldn't have to give Home folder access via Flatseal to fix this.

@TingPing
Copy link
Member

Users such as me shouldn't have to give Home folder access via Flatseal to fix this.

Well this request is to remove access...

General file usage should work fine, only drag-n-drop from random locations won't, until Electron fixes that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Sandbox Permissions are too Restrictive
7 participants