Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo: Partial rewrite #107

Merged
merged 5 commits into from
Apr 12, 2020
Merged

cargo: Partial rewrite #107

merged 5 commits into from
Apr 12, 2020

Conversation

gasinvein
Copy link
Member

@gasinvein gasinvein commented Apr 10, 2020

  • Put git source extraction to separate function
  • Support for (new?) Cargo.lock format without [[metadata]], but with checksum key per-package
  • No need for cargo vendor to generate .cargo-checksum.json for git packages, create stub one ourselves

Tested on ytop (has git sources) and kibi (lockfile without metadata, no git).
Should fix #99

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

togit source generation function
@lgtm-com

This comment has been minimized.

@gasinvein gasinvein marked this pull request as ready for review April 10, 2020 22:10
@lgtm-com
Copy link

lgtm-com bot commented Apr 10, 2020

This pull request fixes 3 alerts when merging 057e3a1 into 062ca7e - view on LGTM.com

fixed alerts:

  • 3 for Unused local variable

@gasinvein gasinvein merged commit dd49b1a into flatpak:master Apr 12, 2020
@gasinvein gasinvein deleted the cargo-fixes branch April 12, 2020 10:13
@gasinvein gasinvein restored the cargo-fixes branch April 12, 2020 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flatpak-cargo-generator doesn't support the new cargo lock format
1 participant