Skip to content
This repository has been archived by the owner on Dec 24, 2022. It is now read-only.

Add org.freedesktop.Sdk.Tools extension point #105

Closed
wants to merge 2 commits into from

Conversation

TingPing
Copy link
Member

@TingPing TingPing commented May 19, 2018

This is similar to org.freedesktop.Sdk.Extension except it is intended for more general tools used by IDEs such as language servers.

This would be useful for applications like emacs, atom, vscode, etc, that are development tools using the Sdk as their runtime.

One thought I don't know the best answer to atm: To make PATH usage easy we want to use merge-dirs but I'm unsure how that deals with conflicts. A workaround could be to merge bin/exports so extensions will only contain clearly chosen binaries which should at least make it manageable but that comes with its own problems. Maybe it just isn't worth it?

(I've also not tested this yet, just thought feedback would be useful)

This is similar to org.freedesktop.Sdk.Extension except it is
intended for more general tools used by IDEs such as language servers.

This would be useful for applications like emacs, atom, vscode, etc.
"directory": "bin/sdk",
"subdirectories": true,
"no-autodownload": true,
"autodelete": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think setting autodelete is right. That means any runtime using this extension will remove all the tools when you uninstall it, but multiple runtimes may use these extensions.

@alexlarsson
Copy link
Member

So, i think this is more or less right. I mean, it means installing a tool does not make it automatically available in PATH/LD_LIBRARY_PATH, so you have to manually do that when using the app. However, this is also what guarantees that installing random tools never break the normal app.

Another alternative is to add a similar extension to the app itself, with a well-known name that everyone shares.

At this point though, nothing really separates the Tools extension from org.freedesktop.Sdk.Extension, other than the base mountpoint. Is there really a gain in having both?

@alexlarsson
Copy link
Member

@gicmo did you try adding an app-specific extension for this?

@TingPing TingPing closed this Nov 29, 2018
@TingPing TingPing deleted the tingping/sdk-tools branch November 29, 2018 22:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants