Apply stronger typing of FlutterMap4 more broadly and opportunistic cleanup/fix #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sentations to more conrcrete types. Mostly project now returns a typed CustomPoint<double>. Use that stronger-typing more consequently.
ignatz
commented
May 11, 2023
| } | ||
|
|
||
| Bounds<double> getPixelBounds(double zoom) { | ||
| final mapZoom = zoom; |
There was a problem hiding this comment.
I believe this to be a bug. It should have been:
final mapZoom = this.zoom;
Otherwise scale will always be 1.0 🤷
There was a problem hiding this comment.
Interesting spot! Will have to test this just to make sure there's no side effects.
|
(Please pull from master. Only Flutter 3.10 is now supported.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FlutterMap4 changes project()'s return type from CustomPoint to CustomPoint, henceforth push the stricter typing further up the stack and do some opportunistic cleanups/fixes.