Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed MapOptions.backgroundColor failing to update #1647

Merged
merged 1 commit into from
Sep 9, 2023
Merged

Fixed MapOptions.backgroundColor failing to update #1647

merged 1 commit into from
Sep 9, 2023

Conversation

lonelyteapot
Copy link
Contributor

Fixes #1646.

I noticed that internally MapOptions were only updated if they differed from the old ones. However, the == operator did not check for backgroundColor, and neither did hashCode.

@JaffaKetchup JaffaKetchup self-requested a review September 9, 2023 12:29
JaffaKetchup
JaffaKetchup approved these changes Sep 9, 2023
View reviewed changes
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must have missed this out when implementing, thanks for this. LGTM.

@JaffaKetchup JaffaKetchup changed the title Fix backgroundColor not being updated Fixed MapOptions.backgroundColor failing to update Sep 9, 2023
@JaffaKetchup JaffaKetchup merged commit 2616ef0 into fleaflet:master Sep 9, 2023
6 checks passed
@lonelyteapot lonelyteapot deleted the patch-1 branch September 14, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaffaKetchup JaffaKetchup JaffaKetchup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] MapOptions.backgroundColor doesn't get updated on rebuilds
2 participants
@lonelyteapot @JaffaKetchup