Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added '{d}' 'dimension'/tile size placeholder support to TileLayer.urlTemplate #1665

Merged
merged 3 commits into from
Oct 2, 2023

Conversation

JaffaKetchup
Copy link
Member

Fixes #1664.

Will only be breaking for users already using '{d}' normally in their URL: nobody.

@bramp
Copy link
Contributor

bramp commented Sep 27, 2023

To catch the issue with users already using {d}, you could warn if additionalOptions contains keys x/y/z/s/d and that it would override what's provided in TileCoordinates/TileLayer. Or maybe that's a support model.

@JaffaKetchup
Copy link
Member Author

I don't think anyone should be using '{d}'. It's very undescriptive as a custom placeholder, does not refer to anything that that is normally used for, such as filling API keys or style params. It's also not valid in a URL outside of this.

@bramp
Copy link
Contributor

bramp commented Sep 27, 2023

While I don't disagree that folks should not be using, Hyrum’s Law states otherwise :). Just trying to avoid someone being confused in future.

@JaffaKetchup
Copy link
Member Author

I'll add it to the Migration instructions out of an abundance of caution! 😂

@JaffaKetchup
Copy link
Member Author

I'm going to bypass normal procedures here, and merge without a second maintainer's approval. This is a very small change, which adds no really new functionality or ideas. v6 needs to get moving at some point!

Happy to make changes if a second maintainer requests it.

@JaffaKetchup JaffaKetchup merged commit 664b3b8 into master Oct 2, 2023
7 checks passed
@JaffaKetchup JaffaKetchup deleted the fix-1664 branch October 2, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add TileLayer urlTemplate placeholder for tileSize
2 participants