Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: document public APIs (part 1) #1776

Merged
merged 17 commits into from
Jan 21, 2024

Conversation

josxha
Copy link
Contributor

@josxha josxha commented Dec 12, 2023

This is a work in progress to document public APIs.

A lot of documentation has been added (master is currently on 603 undocumented members, this pull request crunches this number down to 85).
Marking this pull request as ready to review now because it feels like chasing a moving target with this pr.

If any reviewer has additions or wants to have some things changed, please commit directly to the branch if possible. There are documenations that could probably provide more details. The focus for this pull request was a bit more on quantity than on completeness.

@josxha josxha added this to the v7.0 milestone Dec 12, 2023
@josxha josxha self-assigned this Dec 12, 2023
@josxha josxha force-pushed the document-public-apis branch 3 times, most recently from b1b5544 to 189173f Compare January 18, 2024 11:23
@josxha josxha changed the title chore: document public APIs chore: document public APIs (part 1) Jan 19, 2024
@josxha josxha marked this pull request as ready for review January 19, 2024 20:26
@josxha josxha mentioned this pull request Jan 21, 2024
38 tasks
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will make more changes to documentation over time and in due-course.

@josxha josxha merged commit b2fb7db into fleaflet:master Jan 21, 2024
7 checks passed
@josxha josxha deleted the document-public-apis branch January 21, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants