-
-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf!: add simplification caching to PolygonLayer
& other performance improvements
#1795
Conversation
…lineLayer`) Moved `isClockwise` function into `Polygon` as a static method Added `Polygon` equality and hashing methods Added `Polygon.copyWithNewPoints` method Minor performance improvements to `Polyline` equality and hashing methods Minor syntactic changes to `PolylineLayer.build` method Removed unnecessary `CustomPainter` methods/parts from `PolylineLayer` & `PolygonLayer` Reorganized internal file structure of Polygon Layer Improved Polygon example with 138k points from GeoJson file Seperated `SimplificationToleranceSlider` in example into independent file
I did consider compressing it, but I think the effort required to keep it working on web and quickly could offset the benefit. The '.noformat' part is just a 'random' string to prevent auto-formatters from formatting the JSON and bloating the file size with empty whitespace.
Good spot, will need to investigate that.
I wasn't considering what I was doing fully when I removed the original polygons :D. I'll bring them back to where they were. |
Improved performance stress testing example pages for polygons, polylines, many markers, and many circles Fixed bug in `Polygon.copyWithNewPoints` Deprecated & changed behaviour of `Polygon.isFilled` Fixed unrelated linting/analysis issue
PolygonLayer
PolygonLayer
& other performance improvements
Fixed, was an issue with the
I've split out both the polyline and polygon stress tests into their own page, grouped them with the Many Markers/Circles pages, redesigned those last two for consistency, and added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good pull request! I only found one small thing that could be changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Reflected the same changes made to
PolylineLayer
. Also includes some minor performance enhancements and consistency changes to both.Updated example project and improved consistency and styling. Added
PerformanceOverlay
widget to performance stress testing pages.Also includes some other minor performance improvements (eg. wrapped
RepaintBoundary
around widget tree), and deprecatesPolygon.isFilled
.