-
-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add scale bar layer #1821
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
…port for more painter varieties
…ture support for more painter varieties" This reverts commit 371cbe2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM I think. I also realised that this only supports one unit (metric), but maybe we can change this later.
Yes, I experimented with an imperial scale a bit but it's a bit tricky since the calculations are metric and the the stop points of the scale bar need to be adjusted. Are we ready to merge? |
Yeah I think ready to merge. Maybe something like Google Maps double unit scale bar would work well in future. |
Yep, would be a nice addition. |
To do
lineWidth
is nowstrokeWidth
lineHeight
parameterKnown problems