fix: remove legacy moving_markers and stateful_markers page from example app #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure of what this page is supposed to showcase 😅 |
Not sure either, maybe to test that the map detects and rebuilds the MarkerLayer if the markers change? |
|
They are probably remnants of the old widget/option system. If you find all 172 remnants left you get a special prize 😂. |
josxha
changed the title
|
I removed both pages from the example app. Would it be worth to restructure the example app in general? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix Timer on the moving_markers page, bug discovered inhttps://discord.com/channels/951867686378409984/1215676233346711633/1215677536004997271Bug can be seen here: https://demo.fleaflet.dev/moving_markersRemove legacy pages.