-
-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added interactivity to CircleLayer
& refactored interactivity out into seperate classes
#1886
Conversation
…asses Minor documentation improvements
CircleLayer
CircleLayer
& refactored interactivity out into seperate classes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed 'layers/misc' to 'layers/shared'
I believe it is working correctly. Like a I've renamed the directory to 'shared' :) |
Co-authored-by: Joscha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Uses same framework as in
PolylineLayer
/PolygonLayer
, but less complex (no pre-projection).Additionally, to reduce duplication and make it easier to change behaviour in future, all these layers now use a single system, and are only made responsible for hit testing a single element (via an implemented method invoked by the shared
hitTest
implementation).