refactor: migrate tile rendering from widgets to CustomPainter
#1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced `TileBuilder` with `TileOverlayPainter` Updated examples
…mode) (#1907) Co-authored-by: Sebastian <[email protected]>
JaffaKetchup
commented
Jun 6, 2024
There was a problem hiding this comment.
I can't find as much of a performance improvement as @ReinisSprogis would seem to suggest. It appears to have done barely anything. Can anyone else do some benchmarking?
|
I did some tests and found that CPU usage reduction is still there. With stack approach i was getting ~60+% CPU usage but with CustomPainter ~20-% master branch tile-layer-canvas branch
|
|
@JaffaKetchup It appears that #1907 got merged into this pr instead of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superceeds #1853.